[Codegen] Migrate InnerTiles to VectorizableOpInterface.#23767
Merged
Conversation
hanhanW
requested review from
Groverkss,
MaheshRavishankar,
Max191,
krzysz00,
kuhar,
nirvedhmeshram and
qedawkins
as code owners
hanhanW
requested review from
sommerlukas
and removed request for
MaheshRavishankar and
krzysz00
qedawkins
approved these changes
Mar 12, 2026
compiler/src/iree/compiler/Codegen/Interfaces/VectorizableOpInterface.cpp
Outdated
Show resolved
Hide resolved
sommerlukas
approved these changes
Mar 13, 2026
Comment on lines
+1238
to
+1241
| // CHECK-MASK-LABEL: func @tensor_multi_mma | ||
| // CHECK-FOLD-LABEL: func @tensor_multi_mma | ||
| // CHECK-GATHER-LABEL: func @tensor_multi_mma | ||
| // CHECK-MAP-STORE-LABEL: func @tensor_multi_mma |
Contributor
There was a problem hiding this comment.
What's the purpose of this? Avoid false matches for check lines above?
Contributor
Author
There was a problem hiding this comment.
Yes; I'm going to split the test file in a follow-up. I'm waiting for few in-flight PR landed, then I'll start the work.
compiler/src/iree/compiler/Codegen/Interfaces/VectorizableOpInterface.cpp
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Investigating the failure, may be missing implementation for ValueBoundsOpInterface |
The revision moves the implementation to interface and retires the VectorizeIREEGPUOps pass. The pass and the location of the implementation were not moved during IREEGPU -> IREECodegen move, so they looks wrong. Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
Signed-off-by: hanhanW <[email protected]>
hanhanW
force-pushed
the
users/hanhanW/vec-iface-c5
branch
from
811e3a2 to
39e55ba
Compare
Signed-off-by: hanhanW <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The revision moves the implementation to interface and retires the VectorizeIREEGPUOps pass. The implementation of
ValueBoundsOpInterfaceis done within the PR, because it is used for vector size inference.The pass and the location of the implementation were not moved during IREEGPU -> IREECodegen move, so they looks wrong.